Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix eslint in blocksuite #9232

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: fix eslint in blocksuite #9232

merged 1 commit into from
Dec 20, 2024

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 20, 2024 11:26
@Saul-Mirone Graphite App
Copy link
Contributor Author

Saul-Mirone commented Dec 20, 2024 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot requested a review from forehalo December 20, 2024 11:26
@Saul-Mirone Saul-Mirone force-pushed the 12-20-chore_fix_eslint_in_blocksuite branch from 5ee0618 to c9e9a62 Compare December 20, 2024 11:27
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.41667% with 357 lines in your changes missing coverage. Please review.

Project coverage is 45.32%. Comparing base (bfcc53d) to head (3a82da0).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...idgets/element-toolbar/change-embed-card-button.ts 0.00% 13 Missing ⚠️
...oot-block/widgets/slash-menu/slash-menu-popover.ts 0.00% 13 Missing ⚠️
...gets/drag-handle/watchers/pointer-event-watcher.ts 58.62% 4 Missing and 8 partials ⚠️
...e/presets/nodes/link-node/link-popup/link-popup.ts 0.00% 9 Missing ⚠️
...ess/components/toolbar/shape/shape-tool-element.ts 0.00% 9 Missing ⚠️
...blocks/src/root-block/widgets/ai-panel/ai-panel.ts 0.00% 8 Missing ⚠️
...ksuite/affine/components/src/context-menu/input.ts 0.00% 7 Missing ⚠️
...ine/data-view/src/core/utils/wc-dnd/dnd-context.ts 0.00% 7 Missing ⚠️
...-presets/table/pc/header/database-header-column.ts 0.00% 7 Missing ⚠️
...ocks/src/root-block/clipboard/middlewares/paste.ts 0.00% 7 Missing ⚠️
... and 122 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #9232      +/-   ##
==========================================
+ Coverage   45.29%   45.32%   +0.02%     
==========================================
  Files        2127     2127              
  Lines       97419    97419              
  Branches    16595    16595              
==========================================
+ Hits        44129    44153      +24     
+ Misses      50968    50937      -31     
- Partials     2322     2329       +7
Flag Coverage Δ
server-test 78.26% <ø> (ø)
unittest 31.22% <50.41%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 20, 2024 •
edited
Loading

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 12-20-chore_fix_eslint_in_blocksuite branch from bc37ccf to 3a82da0 Compare December 20, 2024 16:48
@graphite-app graphite-app bot merged commit 3a82da0 into canary Dec 20, 2024
56 checks passed
@graphite-app graphite-app bot deleted the 12-20-chore_fix_eslint_in_blocksuite branch December 20, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@forehalo forehalo Awaiting requested review from forehalo

@EYHN EYHN Awaiting requested review from EYHN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saul-Mirone @Brooooooklyn